Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IWorld #3462

Merged
merged 21 commits into from
Nov 13, 2023
Merged

Introduce IWorld #3462

merged 21 commits into from
Nov 13, 2023

Conversation

limebell
Copy link
Member

This PR introduces IWorld in order to introduce "substate" concept.

The state root hash of the block leads to World, and the World will have Accounts' state root hashes as its value.

For more detail, check CHANGES.md file.

@limebell limebell force-pushed the port/3.6.0-to-iworld branch 2 times, most recently from d82c1d1 to 6a1b19c Compare October 27, 2023 10:05
@CLAassistant
Copy link

CLAassistant commented Oct 27, 2023

CLA assistant check
All committers have signed the CLA.

@limebell limebell force-pushed the port/3.6.0-to-iworld branch 2 times, most recently from 91a635f to b9972ef Compare October 30, 2023 07:15
@limebell limebell marked this pull request as ready for review October 30, 2023 07:15
@limebell limebell force-pushed the port/3.6.0-to-iworld branch from b9972ef to 6a11229 Compare October 31, 2023 04:10
limebell and others added 9 commits November 13, 2023 17:18
Co-authored-by: Chanhyuck Ko <[email protected]>
Co-authored-by: Lee, Suho <[email protected]>
(cherry picked from commit b3e50db)
Co-authored-by: Chanhyuck Ko <[email protected]>
Co-authored-by: Lee, Suho <[email protected]>
(cherry picked from commit fa1b19f)
Co-authored-by: Chanhyuck Ko <[email protected]>
Co-authored-by: Lee, Suho <[email protected]>
(cherry picked from commit cebeb42)
Co-authored-by: Chanhyuck Ko <[email protected]>
Co-authored-by: Lee, Suho <[email protected]>
(cherry picked from commit 4a1a616)
Co-authored-by: Chanhyuck Ko <[email protected]>
Co-authored-by: Lee, Suho <[email protected]>
(cherry picked from commit 429f999)
Co-authored-by: Chanhyuck Ko <[email protected]>
Co-authored-by: Lee, Suho <[email protected]>
(cherry picked from commit c71f8b6)
Co-authored-by: Chanhyuck Ko <[email protected]>
Co-authored-by: Lee, Suho <[email protected]>
(cherry picked from commit 9ab368f)
@OnedgeLee OnedgeLee force-pushed the port/3.6.0-to-iworld branch from c0c0284 to 65ba613 Compare November 13, 2023 08:18

This PR has 2526 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +1850 -676
Percentile : 100%

Total files changed: 83

Change summary by file extension:
.md : +90 -0
.cs : +1760 -676

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@OnedgeLee OnedgeLee merged commit e555add into main Nov 13, 2023
16 of 18 checks passed
@OnedgeLee OnedgeLee deleted the port/3.6.0-to-iworld branch November 28, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants